Page base size #80
Open
Page base size #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloamed
force-pushed
the
palm/font-style
branch
2 times, most recently
from
5a8409c to
8366024
Compare
pauloamed
commented
Jul 18, 2025
pauloamed
commented
Jul 18, 2025
pauloamed
commented
Jul 18, 2025
| export struct Computer { | ||
| Media _media; | ||
| Media const _media; |
There was a problem hiding this comment.
i think this is needed because after build(), the class has internal structures dependent on the media value. so having this attribute media not const allows us to set an invalid state on Computer
|
Guten Morgen @sleepy-monax I don't know how to set copilot to review this beautiful PR so we waste less neurons here. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements CSS Page Size functionality for the Vaev engine, enabling proper handling of page dimensions in print layouts. The implementation adds support for the CSS size property as defined in the CSS Page Module Level 3 specification.
Key changes:
- Added page size parsing and resolution logic with support for predefined paper sizes and custom dimensions
- Refactored the style system to remove separate
ComputedValuesand consolidate font handling withinSpecifiedValues - Implemented page bounds calculation considering margins and orientation
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vaev-engine/values/page.cpp | Added page size parsing with support for paper stock types and custom dimensions |
| src/vaev-engine/values/length.cpp | Added absolute length resolution function for converting CSS units to application units |
| src/vaev-engine/style/specified.cpp | Added page size property to style values and integrated font face handling |
| src/vaev-engine/style/props.cpp | Implemented PageSizeProp parser for CSS size property |
| src/vaev-engine/style/computer.cpp | Added page base size computation and refactored font handling |
| src/vaev-engine/layout/values.cpp | Refactored length resolution to use centralized absolute length conversion |
| src/vaev-engine/layout/builder.cpp | Updated box construction to remove separate font face parameter |
| src/vaev-engine/layout/base.cpp | Simplified Box structure by removing separate font face member |
| src/vaev-engine/driver/print.cpp | Implemented page bounds calculation and media size updates |
| src/vaev-engine/dom/element.cpp | Removed computed values structure and methods |
Comments suppressed due to low confidence (1)
|
Related PR: skift-org/karm#6 |
pauloamed
force-pushed
the
palm/font-style
branch
2 times, most recently
from
3b7f4ae to
e6ea763
Compare
pauloamed
commented
Jul 22, 2025
| ""s, | ||
| (f64)pageRect.size().width * media.resolution.toDppx(), | ||
| (f64)pageRect.size().height * media.resolution.toDppx() | ||
| }; |
There was a problem hiding this comment.
Should we try to name these pages?
pauloamed
commented
Jul 22, 2025
pauloamed
commented
Jul 22, 2025
pauloamed
commented
Jul 22, 2025
pauloamed
force-pushed
the
palm/font-style
branch
from
e6ea763 to
7b9da24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.