Skip to content

Conversation

jjmaksoud
Copy link
Contributor

@jjmaksoud jjmaksoud commented Sep 23, 2025

When calling change_field_selection_values, any default value is not updated. This fix updates the value in the default values table.

https://runbot.odoo.com/odoo/error/230875
TBG-2171

@robodoo
Copy link
Contributor

robodoo commented Sep 23, 2025

Pull request status dashboard

@jjmaksoud jjmaksoud requested review from a team and asno-odoo September 23, 2025 09:42
@jjmaksoud jjmaksoud force-pushed the master-default-selection-maji branch from a043af9 to 52c6ee6 Compare September 23, 2025 13:02
@jjmaksoud
Copy link
Contributor Author

upgradeci retry with always only stock_account account_peppol sale sale_subscription hr

@aj-fuentes
Copy link
Contributor

Could you add a test?

@jjmaksoud jjmaksoud force-pushed the master-default-selection-maji branch 4 times, most recently from 39d29fc to 0142136 Compare September 25, 2025 12:26
@jjmaksoud
Copy link
Contributor Author

upgradeci retry with always only stock_account account_peppol sale sale_subscription hr in all verions

@jjmaksoud
Copy link
Contributor Author

seems all versions does not include < 12 😿

@aj-fuentes
Copy link
Contributor

all verions certainly not XD

@jjmaksoud
Copy link
Contributor Author

upgradeci retry with all versions

When calling change_field_selection_values, any default
value is not updated. This fix updates the value in the
default values table.
@jjmaksoud jjmaksoud force-pushed the master-default-selection-maji branch from 0142136 to 599ac05 Compare September 30, 2025 11:40
Add a test for util.change_field_selection_values
where the selection is also a default value.
@jjmaksoud jjmaksoud force-pushed the master-default-selection-maji branch from 599ac05 to 6af1674 Compare September 30, 2025 11:43
@jjmaksoud
Copy link
Contributor Author

after changing the unit test validation logic, there's no need for the new util clear_cache, removing it

@jjmaksoud
Copy link
Contributor Author

upgradeci retry with always all versions

@jjmaksoud
Copy link
Contributor Author

upgradeci retry with always only stock_account account_peppol sale sale_subscription hr in versions 19.0 18.0 17.0 15.0 16.0 14.0 13.0 12.0 11.0 10.0 9.0 8.0

@aj-fuentes aj-fuentes requested a review from KangOl October 1, 2025 07:36
Copy link
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Contributor

robodoo commented Oct 1, 2025

@jjmaksoud @KangOl because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@KangOl
Copy link
Contributor

KangOl commented Oct 1, 2025

@robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Oct 1, 2025

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Oct 1, 2025
When calling change_field_selection_values, any default
value is not updated. This fix updates the value in the
default values table.

Part-of: #323
Signed-off-by: Christophe Simonis (chs) <[email protected]>
@robodoo robodoo closed this in e9c8bde Oct 1, 2025
@robodoo robodoo added the 19.1 label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants