-
Notifications
You must be signed in to change notification settings - Fork 8
feat: implement IsModSimplifiable in Integer class #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
15686bc to
c29819e
Compare
omnn/math/Exponentiation.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method getExponentiation() has been renamed to eexp() throughout most of the codebase, but this line still uses the old name. Please update to use e.eexp().
omnn/math/Exponentiation.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method getBase() has been renamed to ebase() throughout most of the codebase, but this line still uses the old name. Please update to use e.ebase().
|
General PR Feedback:
|
705b2a8 to
10334a4
Compare
5d68135 to
6323b45
Compare
b1a64ed to
a277058
Compare
a277058 to
bf5c07e
Compare
PR Title/Content MismatchThe PR title suggests implementing Method Naming InconsistenciesSeveral instances of Here are more instances that need to be updated:
These inconsistencies are causing build failures because some parts of the code are using the new method names while others are using the old ones. Implementation Notes for IsModSimplifiable
|
Recommended Verification StepsSince the PR contains both method renaming and implementation of IsModSimplifiable, it's important to verify that:
These verification steps will help ensure that all method renaming is consistent and that the IsModSimplifiable implementation works correctly. |
bf5c07e to
37afe53
Compare
- Add IsModSimplifiable method to Integer class following pattern from IsMultiplicationSimplifiable - Update test cases in Integer_test.cpp to verify implementation - Standardize parameter naming in Valuable.h for consistency Link to Devin run: https://app.devin.ai/sessions/acb21e15defe4b9ba93efb27083da044 Co-Authored-By: Serg Kryvonos <[email protected]>
No description provided.