Automate Docker setup to remove manual post-installation steps (#140) #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What it automates:
MotivationResolves: #140 |
|
Thanks for your pull request. However, there seems to be few questions. It seems docker-compose.yml file has been changed and sections related to db and below has been deleted. Wont this cause issues as db part is also required ? |
|
@oitcode Sir I have fixed it can you check it once |
|
Have you checked that the changes you have made works in your system? Because there seems to be some issues still. Will try to improve the changes you have already made and try to make this work. May take some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
docker-entrypoint.shscript and updates the Dockerfile and docker-compose.yml to fully automate the Laravel setup process when running: