chore(shutdown): allow Shutdown to work on Windows #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
olix0r
reviewed
Jul 12, 2025
kubert/src/shutdown/signals.rs
Outdated
Comment on lines
53
to
54
| let ctrl_break = ctrl_break()?; | ||
| let ctrl_c = ctrl_c()?; |
There was a problem hiding this comment.
Why these signals? Why not the other signals? Can you reference some external resource or prior art that explains what we're doing here?
There was a problem hiding this comment.
You are right. After some research, It becomes clear that the signal that Kubernetes uses for graceful shutdown is Ctrl-Shutdown. I have made the corresponding changes. For reference: https://kubernetes.io/docs/concepts/windows/intro/#compatibility-v1-pod
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
olix0r
reviewed
Aug 5, 2025
Comment on lines
+33
to
+39
| @just-cargo target={{ target }} fetch | ||
|
|
||
| check *args: | ||
| @just-cargo check --workspace --all-targets {{ _features }} {{ args }} | ||
|
|
||
| clippy-all *args: | ||
| @just-cargo clippy --workspace --all-targets --all-features {{ args }} | ||
| @just-cargo target={{ target }} clippy --workspace --all-targets --all-features {{ args }} |
There was a problem hiding this comment.
we need to make this consistent -- if we need it in clippy-all, we should have it on clippy (and check, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the shutdown feature cannot be used on Windows systems. This change abstracts the signal handling functionality so
Ctrl-CandCtrl-Breaksignals are used on WindowsSIGINTandSIGTERMare used on LinuxSigned-off-by: Zahari Dichev [email protected]