Skip to content

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Sep 30, 2025

@m-Peter m-Peter self-assigned this Sep 30, 2025
@m-Peter m-Peter requested a review from a team as a code owner September 30, 2025 13:44
func (db *StateDB) SetCode(
addr gethCommon.Address,
code []byte,
reason tracing.CodeChangeReason,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason parameter was introduced in https://github.com/ethereum/go-ethereum/pull/32525/files#diff-c3757dc9e9d868f63bc84a0cc67159c1d5c22cc5d8c9468757098f0492e0658cR461 , and it seems unused, at least for the implementation of StateDB.

They have another wrapper type (hookedStateDB), which is used for tracing. See: https://github.com/ethereum/go-ethereum/pull/32525/files#diff-abb7c3ba4a7ea95d325d17a5c93b0ebde2c5b43e67f2bc3eb0f76a0c5fc7a8cfR192 .

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fvm/evm/types/call.go 0.00% 9 Missing ⚠️
fvm/evm/emulator/emulator.go 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@m-Peter m-Peter force-pushed the mpeter/bump-geth-to-latest branch from dcb581d to d454c2d Compare October 10, 2025 08:29
@turbolent
Copy link
Member

It might be good to bump the version at the root of the dependency chain, i.e. in the Go SDK, which flow-go depends on ( https://github.com/onflow/flow-go-sdk/blob/master/go.mod#L10). That way all code uses the same version, avoiding potential incompatibilities (There shouldn't be any for patch version bumps, but there have been in the past)

@m-Peter
Copy link
Collaborator Author

m-Peter commented Oct 10, 2025

It might be good to bump the version at the root of the dependency chain, i.e. in the Go SDK, which flow-go depends on ( https://github.com/onflow/flow-go-sdk/blob/master/go.mod#L10). That way all code uses the same version, avoiding potential incompatibilities (There shouldn't be any for patch version bumps, but there have been in the past)

Hey @turbolent , good call-out. I usually forget that flow-go-sdk has a direct dependency on Geth. However, it turns out that it uses it for RLP encoding/decoding.

Usually dependabot takes care of version bumps on flow-go-sdk, as in onflow/flow-go-sdk#924 .
But since it fails due to the Go version bump, I opened onflow/flow-go-sdk#926 .

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-Peter Thank you!

@turbolent
Copy link
Member

We'll probably need to combine this with #8032

@m-Peter m-Peter changed the base branch from master to bastian/update-cadence October 14, 2025 14:59
@turbolent turbolent merged commit 2587d0e into bastian/update-cadence Oct 14, 2025
113 of 114 checks passed
@turbolent turbolent deleted the mpeter/bump-geth-to-latest branch October 14, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants