-
Notifications
You must be signed in to change notification settings - Fork 199
Bump ethereum/go-ethereum
dependency to v1.16.4
#7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
func (db *StateDB) SetCode( | ||
addr gethCommon.Address, | ||
code []byte, | ||
reason tracing.CodeChangeReason, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason
parameter was introduced in https://github.com/ethereum/go-ethereum/pull/32525/files#diff-c3757dc9e9d868f63bc84a0cc67159c1d5c22cc5d8c9468757098f0492e0658cR461 , and it seems unused, at least for the implementation of StateDB
.
They have another wrapper type (hookedStateDB
), which is used for tracing. See: https://github.com/ethereum/go-ethereum/pull/32525/files#diff-abb7c3ba4a7ea95d325d17a5c93b0ebde2c5b43e67f2bc3eb0f76a0c5fc7a8cfR192 .
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dcb581d
to
d454c2d
Compare
It might be good to bump the version at the root of the dependency chain, i.e. in the Go SDK, which flow-go depends on ( https://github.com/onflow/flow-go-sdk/blob/master/go.mod#L10). That way all code uses the same version, avoiding potential incompatibilities (There shouldn't be any for patch version bumps, but there have been in the past) |
Hey @turbolent , good call-out. I usually forget that Usually dependabot takes care of version bumps on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-Peter Thank you!
We'll probably need to combine this with #8032 |
Release Notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.16.4