Skip to content

Conversation

@AlexHentschel
Copy link
Member

@AlexHentschel AlexHentschel commented Oct 15, 2025

Suggested documentation extensions for PR #7983

documentation revisions only

  • added some minimal goDocs for struct
  • updated the Atomicity section for ChunkDataPacks.Store
  • marginal additional comments, typos and updated in various places

@zhangchiqing normally, I would have just merged that into your branch. But I think Tim is still reviewing and I didn't want to interrupt his flow with ongoing revisions to the files. Maybe just wait and see when Tim is done and then could you merge this PR please. Feel free to modify, cherry pick, revert ... wherever you see fit. Thanks

@AlexHentschel AlexHentschel requested a review from a team as a code owner October 15, 2025 04:39
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the documents!

@zhangchiqing zhangchiqing merged commit 7979348 into leo/refactor-stored-chunk-data-pack Oct 15, 2025
@zhangchiqing zhangchiqing deleted the alex/suggestions2_stored-chunk-data-pack branch October 15, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants