Feature/sia #32
Open
Feature/sia #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamranpirwani
commented
Mar 31, 2022
There was a problem hiding this comment.
The changes here overall looks good and mirror the existing upload/download process. As a follow-up, I recommend us to clean up some of the duplicated structure and logic here and better utilize composition to separate out emitting events and the route names from the actual core download/upload logic itself. As it is, we have basically duplicated these files with very very small changes to the files themselves -- this opens us up to having to maintain more code and issues in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR into dev for code review/testing