✨ feature Add a new option to enable otel roundtrip tracing #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no option to enable otel tracing for ocm. Adding EnableOtel option to allow users to config the controller to support otel tracing by wrapping http.RoundTripper with one that starts a span, injects the span context into the outbound request headers, and enriches it with metrics. Signed-off-by: Vu Dinh <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dinhxuanvu
changed the title
|
@frzifus FYI |
|
Related to the Observability enhancement (Issues #931) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there is no option to enable otel tracing for ocm. Adding EnableOtel option to allow users to config the controller to support otel tracing by wrapping http.RoundTripper with one that starts a span, injects the span context into the outbound request headers, and enriches it with metrics.
Related issue(s)
Fixes #