feat: demo null value defaulting #1358
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Jul 16, 2025
| @@ -60,6 +60,16 @@ describe('OFREPProvider should', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it.each([true, false])('returns default if value is null', async (defaultValue) => { | |||
There was a problem hiding this comment.
This test runs with 2 different defaults, and gets the default value both times since we send back a nullish value in OFREP
toddbaert
commented
Jul 16, 2025
Comment on lines
+125
to
+131
| const reason = key.includes('null-value') | ||
| ? StandardResolutionReasons.DEFAULT | ||
| : requestBody.context?.targetingKey | ||
| ? StandardResolutionReasons.TARGETING_MATCH | ||
| : StandardResolutionReasons.STATIC; | ||
|
|
||
| const value = key.includes('null-value') ? null : true; |
There was a problem hiding this comment.
Send back a value=null, variant=null and reason=DEFAULT, this is my preferred proposal for implementing a "defer to code default" evaluation in flagd. I think this would be non-breaking for other implementations.
There was a problem hiding this comment.
Would we need to send a variant at all?
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
demo-null-value-ofrep
branch
from
6d39f15 to
2578068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo only.