-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Use SyncContext from SyncFlagsResponse instead of Metadata Request #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
toddbaert
merged 19 commits into
open-feature:main
from
open-feature-forking:feat/flagd-use-sync-contex
Nov 24, 2025
Merged
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e1ac471
feat: Use SyncContext from GrpcFetch instead of Metadata Request
marcozabel 2ecd945
Add GrpcFetch and InProcess Unit Tests
marcozabel f365db9
Update SyncContext Type Definition
marcozabel d96ada4
Add optional enrichContext for SyncContext
marcozabel ed148f2
Add tests for enrichContext
marcozabel 36b9966
npm update
marcozabel 976136d
fix peer dependency
marcozabel 9d3169b
linting
marcozabel f698e45
merge main
marcozabel c18e574
Remove e2e tag filter to include metadata test
marcozabel 34b1749
Revert: Remove e2e tag filter to include metadata test
marcozabel aed7272
Merge branch 'main' into feat/flagd-use-sync-contex
marcozabel 88985a5
Fix @openfeature imports and runtime errors
marcozabel 633dcb4
Update syncContext type to EvaluationContext
marcozabel 50512ab
Update test-harness to v2.12.0
marcozabel f1c6001
Update test-harness to v2.15.0
marcozabel c9cb190
Merge main
marcozabel cab5491
Update rpc tags
marcozabel b517323
Remvoe unused constants
marcozabel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import type { Hook, EvaluationContext, BeforeHookContext, HookHints } from '@openfeature/server-sdk'; | ||
|
|
||
| export class SyncMetadataHook implements Hook { | ||
| enrichedContext: () => EvaluationContext; | ||
|
|
||
| constructor(enrichedContext: () => EvaluationContext) { | ||
| this.enrichedContext = enrichedContext; | ||
| } | ||
|
|
||
| public before(hookContext: BeforeHookContext, hookHints?: HookHints): EvaluationContext { | ||
| return this.enrichedContext(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.