feat: added-flagsmith-php-provider #1317
Conversation
Signed-off-by: wadii <[email protected]>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Zaimwa9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the Flagsmith provider ecosystem by integrating a new PHP provider into its list. This update aims to enhance the discoverability of available SDKs for developers utilizing Flagsmith within PHP applications, broadening the range of supported technologies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Flagsmith PHP provider to the ecosystem list. The change is straightforward, but I've noticed that the href for the new provider is set to 'TBD'. This will likely result in a broken link on the website. I've suggested using a placeholder that won't break and adding a TODO comment to track the update. This will prevent a poor user experience while still allowing the provider to be listed.
| { | ||
| technology: 'PHP', | ||
| vendorOfficial: true, | ||
| href: 'TBD', |
There was a problem hiding this comment.
Using 'TBD' as the href value will likely result in a broken link on the website. It's better to use a placeholder like # to prevent a 404 error, and add a TODO comment to track this. This makes it clear that the link is not yet available while preventing a broken user experience. Alternatively, if there's a GitHub issue tracking the provider's release, you could link to that.
| href: 'TBD', | |
| href: '#', // TODO: Add link to released PHP provider |
1 participant
This PR
Related Issues
Dependent on provider release to come