Skip to content

Conversation

naughtont3
Copy link
Contributor

@naughtont3 naughtont3 commented Aug 27, 2025

Adds support for the MPI 4.1 error class/code/string removal functions. There are also some tests in the ompi-tests-public repo that can be used to exercise these changes.

@jsquyres
Copy link
Member

Converted to draft while waiting for the Fortran bindings.

@naughtont3
Copy link
Contributor Author

Have added Fortran changes based on what I saw for MPI_Add_error_x(), but have not directly tested the Fortran pieces.

@hppritcha hppritcha moved this to In Progress in MPI 4.1 compliance Sep 4, 2025
@naughtont3 naughtont3 changed the title add MPI_Remove_error_{string,code,class} C fns add MPI_Remove_error_{string,code,class} Sep 9, 2025
@naughtont3 naughtont3 marked this pull request as ready for review September 24, 2025 04:35
@naughtont3 naughtont3 force-pushed the tjn-mpi41-remove-errorclass2 branch from c04a1ed to faf5b33 Compare September 24, 2025 04:40
@naughtont3
Copy link
Contributor Author

Ok, this is now passing a basic fortran check. Should I rebase now?

@naughtont3 naughtont3 force-pushed the tjn-mpi41-remove-errorclass2 branch from 7443d22 to 65d8341 Compare September 30, 2025 03:14
@naughtont3
Copy link
Contributor Author

@hppritcha Can you double check the Fortran bindings looks correct. This compiles/works with my basic tests, but would like someone to take a second look at the INTENT directives.

- add MPI_Remove_error_{class,code,string} C & Fortran bindings
- add MPI_Remove_error_{class,code,string} to docs
- Note: There are also some tests in the ompi-tests-public
  repo (under environ-mgmt) that can exercise these changes.

Signed-off-by: Thomas Naughton <[email protected]>
@naughtont3 naughtont3 force-pushed the tjn-mpi41-remove-errorclass2 branch from a0f9932 to da50804 Compare September 30, 2025 17:59
@hppritcha hppritcha self-requested a review September 30, 2025 19:46
@naughtont3 naughtont3 merged commit 41a68b5 into open-mpi:main Sep 30, 2025
16 checks passed
@naughtont3 naughtont3 moved this from In Progress to Done in MPI 4.1 compliance Sep 30, 2025
@naughtont3 naughtont3 deleted the tjn-mpi41-remove-errorclass2 branch October 3, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants