Revoke coll/han subcomms when a comm is revoked (and general framework) #13420
+127
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitlock <[email protected]>
Signed-off-by: Matthew Whitlock <[email protected]>
|
I don't think this check failure is related to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a way to revoke the subcomms created by the coll modules, processes can get stuck waiting on sub-operations of a collective on a revoked communicator.
I chose to put the top-level coll_revoke_local into the comm's c_coll object as a function pointer, but that's only to maintain the same programming pattern as the other functions. The top-level function is static, and calls coll_revoke_local on the comm for each of it's active modules.