-
Notifications
You must be signed in to change notification settings - Fork 124
CMake: Support RelWithDebInfo configuration #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,8 @@ param ( | |
[Parameter(Mandatory=$false)] | ||
[string] $flavor = "vs2022", | ||
|
||
## The target build configuration. Valid values: "Release" and "Debug" | ||
## The target build configuration. Valid values: "Release", "Debug" and | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oxford comma is less needed here but I'd still recommend it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pmetzger: My writing habits were pretty ingrained by my PhD advisor's admin, who proofed and edited my dissertation. She completely disabused me of writing with Oxford commas. Happy to have a five gin martini debate elsewhere. |
||
## "RelWithDebInfo" | ||
[Parameter(Mandatory=$false)] | ||
[string] $config = "Release", | ||
|
||
|
@@ -297,7 +298,7 @@ if (!$testonly) | |
} | ||
|
||
## Validate the requested configuration. | ||
if (!@("Release", "Debug").Contains($config)) | ||
if (!@("Release", "Debug", "RelWithDebInfo").Contains($config)) | ||
{ | ||
@" | ||
${scriptName}: Invalid configuration: "${config}". | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ Configure and build simh simulators on Linux and *nix-like platforms. | |
--clean (-x) Remove the build subdirectory | ||
--generate (-g) Generate the build environment, don't compile/build | ||
--cache '--generate' and show CMake's variable cache | ||
--parallel (-p) Enable build parallelism (parallel builds) | ||
--parallel (-p) Enable parallel builds | ||
--notest Do not execute 'ctest' test cases | ||
--noinstall Do not install SIMH simulators. | ||
--testonly Do not build, execute the 'ctest' test cases | ||
|
@@ -27,7 +27,8 @@ Configure and build simh simulators on Linux and *nix-like platforms. | |
msys2 | ||
mingw | ||
ucrt | ||
--config (-c) Specifies the build configuration: 'Release' or 'Debug' | ||
--config (-c) Specifies the build configuration: 'Release', 'Debug' or | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I recommend an Oxford comma again. |
||
'RelWithDebInfo' | ||
|
||
--target Build a specific simulator or simulators. Separate multiple | ||
targets with a comma, e.g. "--target pdp8,pdp11,vax750,altairz80,3b2" | ||
|
@@ -211,7 +212,7 @@ while true; do | |
;; | ||
-c | --config) | ||
case "$2" in | ||
Release|Debug) | ||
Release|Debug|RelWithDebInfo) | ||
buildConfig=$2 | ||
shift 2 | ||
;; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An Oxford comma would be good here, I think. It gets confusing otherwise.