Don't crash if FMUs log with category=NULL #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #796.
|
Ser bra ut dette. |
|
I don't understand the build failures. I don't think they are related to this particular PR, and I can't reproduce them locally even using the same Conan version as that used in CI. |
|
Tested locally with an fmiCpp FMU provided by @SSkjong and confirmed that it works: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #796.
We don't have any straightforward way to test this right now, since our test FMUs aren't easily modifiable. Perhaps @SSkjong, who discovered the issue, can test with the FMU that triggered it?