-
Notifications
You must be signed in to change notification settings - Fork 497
[CMAKE] upgrade cmake minimum version to 3.16 #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMAKE] upgrade cmake minimum version to 3.16 #3599
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
+ Coverage 90.02% 90.03% +0.02%
==========================================
Files 220 220
Lines 7069 7069
==========================================
+ Hits 6363 6364 +1
+ Misses 706 705 -1 🚀 New features to boost your workflow:
|
install/test/cmake/component_tests/exporters_elasticsearch/CMakeLists.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok overall, with some questions on remaining cmake policies.
Also, please add an "important changes" entry in CHANGELOG.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Fixes #3598
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes