Test with --sun-misc-unsafe-memory-access=deny
#7683
+409
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
--sun-misc-unsafe-memory-access=deny
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7683 +/- ##
=========================================
Coverage 90.12% 90.12%
Complexity 7187 7187
=========================================
Files 814 814
Lines 21700 21700
Branches 2123 2123
=========================================
Hits 19557 19557
Misses 1477 1477
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
test-unsafe-deny
branch
18 times, most recently
from
7ba6108 to
ce60875
Compare
mock-server uses older LMAX disruptor which requires Unsafe
trask
force-pushed
the
test-unsafe-deny
branch
from
ce60875 to
4184b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackery ensued because some test-only dependencies don't support
--sun-misc-unsafe-memory-access=denyyet, but hopefully this should give us the confidence we need that the SDK will not break once this becomes the default in a future Java release.