Skip to content

Conversation

overbalance
Copy link
Contributor

@overbalance overbalance commented Aug 28, 2025

Which problem is this PR solving?

Upgrade to eslint 9 because 8 is EOL.

Short description of the changes

  • Remove all .eslintignore files in packages
  • Remove all lint and lint:fix commands in packages
  • Add lots of rules to warn on invalid ts and js called out by the new eslint 9 default recommendations
  • Replace the license plugin
  • Replace the node plugin

@overbalance overbalance force-pushed the overbalance/repair-eslint branch from a45b322 to 86027cf Compare October 13, 2025 16:13
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pichlermarc

Thanks for working on this! 🙌
Running eslint locally, I'm seeing an OOM error......

Thanks! I'm not sure what to do about this one. I don't think you can run eslint without nx because it will try to add all matching files to the end of your command and fail (as you saw).

Thanks, all good - I think I just missed that nx lint target already does what I wanted it to. :)

*.yaml
!package.json

/.nx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nx cache does not contain any js or ts files

% npx eslint --print-config .nx/cache/18287085831844831640/packages/instrumentation-router/src/version.ts
{
  "settings": {
    "node": {
      "tryExtensions": [
        ".js",
        ".json",
        ".node",
        ...

*.yaml
!package.json

/.nx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only the "version.ts" files.

% find .nx | rg -v build/ | rg '\.(ts|js)$'
.nx/cache/11224883197310830386/packages/instrumentation-mysql2/src/version.ts
.nx/cache/5581609661682288038/packages/instrumentation-document-load/src/version.ts
.nx/cache/16519942250677500878/packages/instrumentation-connect/src/version.ts
...

@trentm trentm merged commit c352766 into open-telemetry:main Oct 14, 2025
32 of 33 checks passed
@overbalance overbalance deleted the overbalance/repair-eslint branch October 16, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:auto-configuration-propagators pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-kafkajs pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-openai pkg:instrumentation-oracledb pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagation-utils pkg:propagator-aws-xray pkg:propagator-aws-xray-lambda pkg:propagator-instana pkg:propagator-ot-trace pkg:redis-common pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sampler-aws-xray pkg:sql-common pkg:test-utils pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.