-
Notifications
You must be signed in to change notification settings - Fork 611
chore(eslint): upgrade to eslint 9 #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): upgrade to eslint 9 #3001
Conversation
…r-license-header to get support for a *pattern* of allowable Copyright sections Manually adjust instr-oracledb and resource-detector-gcp slightly for the defined Copyright format.
a45b322
to
86027cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 🙌
Runningeslint
locally, I'm seeing an OOM error......Thanks! I'm not sure what to do about this one. I don't think you can run
eslint
without nx because it will try to add all matching files to the end of your command and fail (as you saw).
Thanks, all good - I think I just missed that nx
lint
target already does what I wanted it to. :)
*.yaml | ||
!package.json | ||
|
||
/.nx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nx cache does not contain any js or ts files
% npx eslint --print-config .nx/cache/18287085831844831640/packages/instrumentation-router/src/version.ts
{
"settings": {
"node": {
"tryExtensions": [
".js",
".json",
".node",
...
*.yaml | ||
!package.json | ||
|
||
/.nx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like only the "version.ts" files.
% find .nx | rg -v build/ | rg '\.(ts|js)$'
.nx/cache/11224883197310830386/packages/instrumentation-mysql2/src/version.ts
.nx/cache/5581609661682288038/packages/instrumentation-document-load/src/version.ts
.nx/cache/16519942250677500878/packages/instrumentation-connect/src/version.ts
...
Which problem is this PR solving?
Upgrade to eslint 9 because 8 is EOL.
Short description of the changes
lint
andlint:fix
commands in packages