Skip to content

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 24, 2025

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner July 24, 2025 05:58
@lalitb lalitb marked this pull request as draft July 24, 2025 05:59
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 28.46715% with 490 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.4%. Comparing base (6b2d4c1) to head (1e42374).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...try-exporter-geneva/geneva-uploader/src/msi/mod.rs 0.0% 272 Missing ⚠️
...eneva/geneva-uploader/src/config_service/client.rs 4.4% 85 Missing ⚠️
...try-exporter-geneva/geneva-uploader/src/msi/ffi.rs 14.2% 66 Missing ⚠️
...etry-exporter-geneva/geneva-uploader/src/client.rs 0.0% 28 Missing ⚠️
...y-exporter-geneva/geneva-uploader/src/msi/error.rs 65.9% 15 Missing ⚠️
...y-exporter-geneva/geneva-uploader/src/msi/types.rs 89.5% 15 Missing ⚠️
...ter-geneva/geneva-uploader/src/msi/token_source.rs 65.3% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #386     +/-   ##
=======================================
- Coverage   48.2%   46.4%   -1.9%     
=======================================
  Files         69      74      +5     
  Lines       9586   10397    +811     
=======================================
+ Hits        4626    4826    +200     
- Misses      4960    5571    +611     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/// Run with: cargo test --features msi_auth test_gcs_msi_authentication -- --ignored
///
/// Note: Must run on Azure infrastructure where the managed identity is assigned
#[tokio::test]

Check failure

Code scanning / CodeQL

Cleartext logging of sensitive information High

This operation writes
moniker_info.account_group
to a log file.
/// - MSI identity variables: TEST_MSI_OBJECT_ID (or alternatives)
///
/// Run with: cargo test --features msi_auth test_msi_vs_certificate_authentication -- --ignored
#[tokio::test]

Check failure

Code scanning / CodeQL

Cleartext logging of sensitive information High

This operation writes
cert_token_endpoint
to a log file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant