Fix #2795: When using --image with exec codex hangs, and fix image detectio… #2843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes bug where
codex exec --image
hangs for 10+ minutes, and resolves inconsistent image handling between TUI and exec.Why?
Bug 1:
codex exec --image ./photo.jpg "describe this"
causes indefinite hanging due to race condition in event loopBug 2:
codex exec "what do you see in ./photo.jpg?"
treats image paths as text (shows metadata) while TUI correctly displays imagesHow?
codex-common/path_utils
to prevent future inconsistenciesResult: Both explicit (
--image
) and implicit (./image.jpg
in text) image references now work consistently across TUI and exec.Testing
codex exec --image ./test.jpg "what do you see?"
- no longer hangscodex exec "describe ./test.jpg"
- now shows actual image instead of metadataCloses #2795