fix(bug): Code injection evalcommand
#1584
Open
+15
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evals/evals/elsuite/multistep_web_tasks/docker/flask-playwright/app.py
Line 184 in cdb8ce9
fix the issue need to eliminate the use of
eval
and replace it with a safer alternative. Instead of dynamically evaluating arbitrary code, we can implement a controlled execution environment where only predefined commands are allowed. This can be achieved by using a dictionary or a similar structure to map command strings to corresponding functions.Steps to fix:
eval
call with a lookup in the dictionary, followed by a function call.command
input to ensure it matches one of the allowed commands._execute_command
function to use this safer approach.