Skip to content

feat(openAPI-union) Add type support for unions with additionalProperties to provide ts intellisense #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

remy90
Copy link

@remy90 remy90 commented Aug 15, 2025

Thank you for your work on this package, much appreciated! I came across string & {} recently to get 'loose autocomplete' on a string and thought it might help here.

Changes

What does this PR change? Link to any related issue(s).
A union of type "A" | "B" | "C" will now provide intellisense options from the union but also accept non-union string entries

How to Review

How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@remy90 remy90 requested a review from a team as a code owner August 15, 2025 13:46
@remy90 remy90 requested a review from drwpow August 15, 2025 13:46
Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for openapi-ts canceled.

Name Link
🔨 Latest commit 8426fa2
🔍 Latest deploy log https://app.netlify.com/projects/openapi-ts/deploys/689f4246062c420008cfc6a2

Copy link

changeset-bot bot commented Aug 15, 2025

⚠️ No Changeset found

Latest commit: 8426fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remy90 remy90 changed the title Add type support for unions with additionalProperties to provide ts intellisense feat(open-API-union) Add type support for unions with additionalProperties to provide ts intellisense Aug 21, 2025
@remy90 remy90 changed the title feat(open-API-union) Add type support for unions with additionalProperties to provide ts intellisense feat(openAPI-union) Add type support for unions with additionalProperties to provide ts intellisense Aug 21, 2025
@remy90
Copy link
Author

remy90 commented Aug 22, 2025

@duncanbeevers I noticed you've picked up a similar PR area, any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant