Query WebFinger for OIDC issuer before fetching /.well-known/openid-configuration
#776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….well-known/openid-configuration`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the OpenCloud client relies on the
PROXY_OIDC_REWRITE_WELLKNOWNhack to discover the IDP's configuration (except for the initial login, see also #771).To be able to get rid of this workaround (see also owncloud/ocis#11542 for problems with this approach), this PR changes the
OAuth::fetchWellKnownmethod to get the issuer's location via WebFinger before fetching the issuer's/.well-known/openid-configuration.These changes also make it possible to get additional data from the WebFinger as required for #246 (comment), for example.
This PR depends on my previous PR #771, the additional changes are in 31745c4.