Direct gene.id modification warning message. #1424
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that modifying the ID can cause so many issues that we should consider disallowing that. |
cdiener
reviewed
Oct 9, 2025
| "Use cobra.manipulation.modify.rename_genes to safely rename genes.", | ||
| UserWarning | ||
| ) | ||
| super(Gene, self.__class__).id.fset(self, new_id) |
There was a problem hiding this comment.
As Moritz said, better not even set it but throw an error with the same message instead of a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike with metabolites or reactions, direct modification of Gene class id property may lead implicit gene duplications in the model. The user should be notified that there is a special, safe function designed just for that.
Im just not quite sure about the
super(Gene, self.__class__).id.fset(self, new_id)syntax and will welcome any comments.