Skip to content

Conversation

@fdamato
Copy link
Collaborator

@fdamato fdamato commented Oct 1, 2025

No description provided.

@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch 3 times, most recently from f13432a to 4e77756 Compare October 1, 2025 02:50
@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch from 4e77756 to e248543 Compare October 1, 2025 02:53
@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch from c35aace to f28f146 Compare October 2, 2025 03:27
@fdamato
Copy link
Collaborator Author

fdamato commented Oct 2, 2025

@bluegate010 while addressing feedback, I also made few changes to GET_ENVELOPE_SIGNED_CSR to make it consistent with the other commands.

@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch 13 times, most recently from fb292a4 to e968925 Compare October 2, 2025 04:57
@fdamato fdamato requested a review from bluegate010 October 2, 2025 04:58
@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch 2 times, most recently from 62c84ca to 81aa721 Compare October 2, 2025 05:06

When a PKI owner issues an identity certificate for a device key (such as IDevID or LDevID), they provision a certificate chain to the device that includes the PKI-issued identity certificate for the device key.

**Important**: Devices SHALL NOT expose CSRs for LEAF certificates. This ensures that endorsements work across different use cases (e.g., attestation, secure sessions) since each use case may have different LEAF certificates while sharing the same endorsement chain.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is a requirement for devices? Seems like if the device advertises a KeyPairID that happens to be a leaf cert, the CSR should correctly indicate that it's a leaf through the derivation input OIDs. Maybe that should be the requirement, that LEAF certs, if advertised, must be distinguishable based on their derivation inputs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Devices CAN expose CSRs for LEAF keys
  • What's restricted is the PROVISIONING of endorsed LEAF certificates
  • The endorsement chain stops before the LEAF level

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it illegal for a device to support provisioning certs at the LEAF level? If that's what the device supports, and the device advertises that it is in fact a leaf, then it's on the PKI operator if they want to do that to themselves, right?

Copy link
Collaborator Author

@fdamato fdamato Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that could only work under the specific condition that the device uses only that key for Attestation. If we are not doing that, we are losing compatibility with SPDM

@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch from 81aa721 to ccda53d Compare October 3, 2025 20:16
@fdamato fdamato force-pushed the fadamato/dip_update_provisioning_flow branch from ccda53d to 3fb2354 Compare October 3, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants