-
Notifications
You must be signed in to change notification settings - Fork 35
Changes to address full EAT profile requirements #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes to address full EAT profile requirements #78
Conversation
| **Mandatory Claims (1-6)**: These claims are **REQUIRED** for all attestations | ||
| and provide the minimum necessary information for verifier appraisal policies: | ||
| and provide the minimum necessary information for verifier appraisal policies. Any attestation that fails | ||
| to include all mandatory claims **MUST** be rejected by the verifier: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUST be rejected by the verifier
Why would the Verifier care? Especially for the non-verifiable claims. I am not sure the production Verifier itself is the right place to (always) check evidence for compliance / conformance to an EAT profile. That could be a separate tool. Maybe @laurencelundblade has an opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profile shouldn`t enforce policy for the verifiers, however we can clarify that Mandatory Claim is what the Verifier would expect from a EAT that use this profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See new change.
| size constraints apply: | ||
|
|
||
| * The complete CWT token (including the certificate chain in the unprotected header) **SHALL NOT** exceed 64kB. This limitation aligns with the SPDM Measurement block size limit, as most OCP Attesters are expected to rely on SPDM for EAT conveyance. | ||
| * The complete CWT token (including the certificate chain in the unprotected header) **SHALL NOT** exceed 64kB (post-encoding). This limitation aligns with the SPDM Measurement block size limit, as most OCP Attesters are expected to rely on SPDM for EAT conveyance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, as it may creates more confusion
|
|
||
| Implementations **MUST** account for the following signature size | ||
| implications when calculating total CWT size against the 64kB limit: | ||
| implications when calculating total (post-encoding) CWT size against the 64kB limit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "post-encoding"
69b3351 to
1acfe25
Compare
Addressing opencomputeproject#64 Signed-off-by: Giridhar Mandyam <[email protected]>
1acfe25 to
99599a9
Compare
Addressing #64