systemd: retry when the dbus connection returns EAGAIN #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianghao65536
force-pushed
the
eagain-retry
branch
from
7efe761 to
350f6fc
Compare
Signed-off-by: jianghao65536 <[email protected]>
jianghao65536
force-pushed
the
eagain-retry
branch
from
350f6fc to
c391dec
Compare
lifubang
suggested changes
Oct 18, 2025
| "testing" | ||
| ) | ||
|
|
||
| func TestParallelConnection(t *testing.T) { |
There was a problem hiding this comment.
Although systemd is widely used, we should skip this test if the system isn't running it. You can implement this check as shown here:
cgroups/systemd/systemd_test.go
Lines 76 to 79 in 6a793b6
kolyshkin
reviewed
Oct 24, 2025
| defer wg.Done() | ||
| _, err := dm.newConnection() | ||
| if err != nil { | ||
| t.Error(err) |
There was a problem hiding this comment.
Maybe this should be t.Fatal, we don't want a bunch of similar errors.
kolyshkin
reviewed
Oct 24, 2025
There was a problem hiding this comment.
I tried the test from here (without the fix, just the test case) on three different distros:
- Fedora 42: kernel 6.16.10-200.fc42.x86_64, systemd 257.9-2.fc42
- Alma 9: kernel 5.14.0-570.37.1.el9_6.x86_64, systemd 252-51.el9.alma.1
- Alma 8: kernel 4.18.0-553.16.1.el8_10.x86_64, systemd 239-82.el8_10.1
and it does not fail.
This might be because Red Hat has backported systemd fix, so what distro do you recommend to try so we can see the test fails before the fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before version 254, systemd used the glibc macro SOMAXCONN to set the backlog. Prior to Linux 5.4, SOMAXCONN was set to 128. If the number of instantaneous connections exceeds this value, newConnection will return EAGAIN, which can cause runc to fail when creating containers.