config-linux: define default clos for linux.intelRdt #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
marquiz
force-pushed
the
devel/rdt-default-clos
branch
from
aa75def to
ad23560
Compare
giuseppe
reviewed
Aug 4, 2025
config-linux.md
Outdated
| @@ -742,6 +742,8 @@ If `intelRdt` is not set, the runtime MUST NOT manipulate any `resctrl` pseudo-f | |||
| The following parameters can be specified for the container: | |||
|
|
|||
| * **`closID`** *(string, OPTIONAL)* - specifies the identity for RDT Class of Service (CLOS). | |||
| As a special case, value `.` means that the container should be assigned to the default CLOS (the | |||
There was a problem hiding this comment.
would '/' be more explicit? The value '.' looks to me like the expectation is the "current CLOS"
There was a problem hiding this comment.
I'm fine with this, too. I was struggling with the name myself
There was a problem hiding this comment.
No other comments so I now changed this to /.
marquiz
force-pushed
the
devel/rdt-default-clos
branch
from
ad23560 to
2cfef25
Compare
|
Updated: as per @giuseppe's suggestion, changed name of the root/default group to |
thaJeztah
reviewed
Aug 15, 2025
config-linux.md
Outdated
| @@ -742,6 +742,8 @@ If `intelRdt` is not set, the runtime MUST NOT manipulate any `resctrl` pseudo-f | |||
| The following parameters can be specified for the container: | |||
|
|
|||
| * **`closID`** *(string, OPTIONAL)* - specifies the identity for RDT Class of Service (CLOS). | |||
| As a special case, value `/` means that the container should be assigned to the default CLOS (the | |||
There was a problem hiding this comment.
Thanks. Changed to MUST
Specify "/" as an explicit value for linux.intelRdt.closID to assign a container to the default CLOS, corresponding to the root of the resctrl filesystem. This addition is important after the recently introduced intelRdt.enableMonitoring field. There is no way to express "enable monitoring but keep the container in the default CLOS". Users would otherwise have to rely on pre-created CLOSes or may quickly exhaust available CLOS entries - in some configurations the number of available CLOSes (on top of the default) may be as low as three. Signed-off-by: Markus Lehtonen <[email protected]>
marquiz
force-pushed
the
devel/rdt-default-clos
branch
from
2cfef25 to
e51a839
Compare
marquiz
added a commit
to marquiz/runc
that referenced
this pull request
Aug 15, 2025
Makes it possible e.g. to enable monitoring (linux.intelRdt.enableMonitoring) without creating a CLOS (resctrl group) for the container. Implements opencontainers/runtime-spec#1289. Signed-off-by: Markus Lehtonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify "/" as an explicit value for linux.intelRdt.closID to assign a container to the default CLOS, corresponding to the root of the resctrl filesystem.
This addition is important after the recently introduced intelRdt.enableMonitoring field. There is no way to express "enable monitoring but keep the container in the default CLOS". Users would otherwise have to rely on pre-created CLOSes or may quickly exhaust available CLOS entries - in some configurations the number of available CLOSes (on top of the default) may be as low as three.
Note
Alternative names I considered were e.g.
.,/default,/root,default/,root/(i.e. something that is not a possible/valid > name in the resctrl fs).