Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Nov 20, 2025

Related to: https://issues.redhat.com/browse/RHAIENG-1959

Description

Pin version on compressed-tensors=0.12.2 to be compatible with llmcompressor=0.8.1

How Has This Been Tested?

konflux-build image: quay.io/opendatahub/odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-ubi9:on-pr-8e0fd264b335c216951257415ad6cfc3430ba6cb-linux-x86-64

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated core Python dependencies to newer, more reproducible versions.
    • Upgraded compressed-tensors to 0.12.2 and pinned it as an explicit dependency.
    • Removed an unused frozendict dependency.
    • Updated many scientific and data libraries (e.g., scipy, pandas, pyyaml, scikit-learn) to newer releases.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Nov 20, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Walkthrough

Updates compressed-tensors from 0.11.0 to 0.12.2 across project files, adds explicit dependency pins, removes override constraints, removes the frozendict entry in a runtime lock, and upgrades numerous runtime dependencies with updated URLs/hashes and an added --index-url comment parameter.

Changes

Cohort / File(s) Change Summary
Jupyter PyTorch+LLMCompressor config
jupyter/pytorch+llmcompressor/ubi9-python-3.12/pylock.toml, jupyter/pytorch+llmcompressor/ubi9-python-3.12/pyproject.toml
Replaces compressed-tensors 0.11.0 metadata with 0.12.2 metadata (version, sdist/wheel URLs, hashes). Adds explicit dependency compressed-tensors==0.12.2 to pyproject.toml and removes the prior override pin.
Runtimes PyTorch+LLMCompressor lock
runtimes/pytorch+llmcompressor/ubi9-python-3.12/pylock.toml
Adds --index-url=https://pypi.org/simple to autogenerated comment. Updates compressed-tensors to 0.12.2 (sdist/wheel URLs and hashes). Removes frozendict entry. Upgrades many packages (e.g., scipy, pandas, pyyaml, torch, transformers, scikit-learn, frozenlist) with new versions, source URLs, and hashes.
Runtimes PyTorch+LLMCompressor project config
runtimes/pytorch+llmcompressor/ubi9-python-3.12/pyproject.toml
Adds/pins compressed-tensors==0.12.2 in dependencies and removes the previous override-dependencies block that pinned compressed-tensors.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Inspect runtimes/.../pylock.toml for correctness of many updated URLs/hashes and ensure no accidental truncation or formatting errors.
  • Verify that removing frozendict does not break dependency resolution or runtime imports.
  • Confirm compressed-tensors==0.12.2 compatibility with the pinned torch/transformers versions in both jupyter and runtime configs.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: pinning compressed-tensors to version 0.12.2 for compatibility with llmcompressor 0.8.1, which aligns with the actual changes in pylock.toml and pyproject.toml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description includes the required sections with adequate detail about the purpose (pinning compressed-tensors to 0.12.2), testing information (konflux-build image provided), and all self-checklist items marked complete.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added size/m and removed size/m labels Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/m and removed size/m labels Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 677fecf link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants