Chore/sc 56156/migrate es geoshape java plugin #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which allows us to apply an auto-formatting. Also add '-Xlint' option to show the deprecation warnings at compile time. Add two configuration files for formatting and import order (the same as Elasticsearch)
also remove unused attributes and imports
* fix a conflict issue with hamcrest * you can write unit test with Junit4 and ESTestCase
prepare the legacygeo refactoring to get rid of this geo library in order to replace it by jts geometry and elasticsearch.geom
…csearch.geo lib * add a function for each Geometry type: Line, LinearRing, Polygon, MultiPolygon, GeometryCollection * add unit tests based on the legacy one
Just depending on jts.io, jts geom and elasticsearch.common.geo libs to handle the Geometry objects.
remove the JAR file in the libs folder and also get rid of mentionning the dependency from the build Gradle file.
garaud
force-pushed
the
chore/sc-56156/migrate-es-geoshape-java-plugin
branch
from
f8200e3 to
029cda8
Compare
5k4nd
reviewed
Oct 8, 2025
src/yamlRestTest/resources/rest-api-spec/test/GeoExtension/20_geo_ingest_processor.yml
Outdated
Show resolved
Hide resolved
5k4nd
reviewed
Oct 8, 2025
src/yamlRestTest/resources/rest-api-spec/test/GeoExtension/20_geo_ingest_processor.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it work for Elastic 8.18
update the gradle build adding the spotless plugin
which allows us to apply an auto-formatting. Also add
-Xlintoption to show the deprecation warnings at compile time.Add two configuration files for formatting and import order (the same as Elasticsearch)
apply auto-formatting thanks to the spotless plugin
gradle build for Elastic 8.18.1
adapt the plugin with the Elastic 8 internal API
processor: get rid of a deprecation warning about
XContent.createParseralso remove unused attributes and importsremove some unused imports
update the Yaml REST unit tests
Also remove the legacy geo libs from the dependency adapting the code to handle Geometry objects thanks to JTS and elasticsearch.common.geo libs.