MarkdownText: Support images #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richterb
force-pushed
the
feat/markdown-images
branch
from
d4c0ad1 to
0c567f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal for this PR is to add support for images in Markdown content rendered by MarkdownText.
Changes
imagefeature ofMarkdownItMarkdownItwhile we're at it. There's no direct need for it, but why not keep up to date. No breaking change in the changelogBreaking Changes
None
Changelog
We added support for images in MarkdownText.
Open discussion
Security-wise, MarkdownIt validates and normalizes URLs (https://github.com/markdown-it/markdown-it/blob/master/lib/rules_inline/image.mjs#L40-L45) with what I think is a very good approach: https://github.com/markdown-it/markdown-it/blob/master/lib/index.mjs#L34-L61
To be tested
Does it render images consistently in Storybook?
Does the Text block in Studio work as well as before?
Review checklist