align TIR-infra.html.tmpl to TIR.html.tmpl #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metmajer
approved these changes
Jun 30, 2025
Member
metmajer
left a comment
metmajer
left a comment
There was a problem hiding this comment.
Thank you, @matzehecht, for taking the time not only to point out a mistake of ours, but to provide a resolution. Much appreciated!
Member
|
Awaiting a quick review from @hrcornejo. |
hrcornejo
approved these changes
Jul 1, 2025
BraisVQ
pushed a commit
that referenced
this pull request
Jul 10, 2025
Co-authored-by: Matthias Hecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document history in the TIR for ods-infra components is always empty as the condition in line 306 references section 1 instead of section 7.
Additionally, the document history for TIR components only include the content of the respective Jira ticket and does not provide the automated part. The TIRs for component of other types do include that automated part like in other document types. This seems unintentional to me. I therefore assume this is a bug and aligned the whole documentation history section of
templates/TIR-infra.html.tmplwith the one fromtemplates/TIR.html.tmpl. If this is different by intention I can revert that part and only submit the change of line 306.Unfortunately, I do not have a setup in which I can test those changes. Can this be done by one of the maintainers or can somebody help me to setup such a test environment?