polish(majdoddin): use ENV_REGISTRY for loading AlphaZero simulation environments #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background (DI-engine pattern)
DI-engine already loads classes for collector and evaluator environments via
ENV_REGISTRY(usingget_vec_env_setting()inDI-engine's
base_env.py). However, the simulation environment class used by MCTS in AlphaZero policies was still loaded throughhardcoded imports.
Changes
This PR completes the registry-based approach by refactoring simulation environment class loading to use
ENV_REGISTRY, matching thepattern used by DI-engine for collector/evaluator environments.
train_alphazero.pyto passfull_cfgandcreate_cfgto policy config_get_simulation_env()in all 3 AlphaZero policies:lzero/policy/alphazero.pylzero/policy/gumbel_alphazero.pylzero/policy/sampled_alphazero.pyBenefits
Testing
Tested and verified with:
All tests passed successfully.