Skip to content

Conversation

@speedfl
Copy link
Contributor

@speedfl speedfl commented Oct 4, 2025

Pull Request template

Why is this PR required? What issue does it fix?:

See #285

What this PR does?:

This PR excludes empty selectors. Instead of using == nil it use len(). It also adds some new unit tests.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

@speedfl speedfl requested a review from a team as a code owner October 4, 2025 13:29
Copy link
Member

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.54%. Comparing base (cab53c4) to head (ebef8e1).
⚠️ Report is 53 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #286      +/-   ##
===========================================
- Coverage    37.91%   37.54%   -0.38%     
===========================================
  Files           36        1      -35     
  Lines         3373      783    -2590     
===========================================
- Hits          1279      294     -985     
+ Misses        2012      480    -1532     
+ Partials        82        9      -73     
Flag Coverage Δ
integrationtests 37.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niladrih niladrih changed the title feat(provisioner): Support empty selectors fix(provisioner): support empty selectors Oct 16, 2025
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this change @speedfl!

@niladrih
Copy link
Member

Let me know if you're ready to merge @speedfl. I'll merge this on Monday (20th Oct.) unless you confirm.

@speedfl
Copy link
Contributor Author

speedfl commented Oct 16, 2025

I am ready let's go 🚀

@tiagolobocastro tiagolobocastro merged commit c4e02da into openebs:develop Oct 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[provisioner] StatefulSet with empty selector are blocked

4 participants