-
Notifications
You must be signed in to change notification settings - Fork 81
feat: add pagination support to fetch all badge templates #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add pagination support to fetch all badge templates #2895
Conversation
|
Thanks for the pull request, @luisfelipec95! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@luisfelipec95 Thanks for this. It looks like some of the tests are failing, can you have a look? |
| # For each iteration, fetch data using the 'next_page_url' provided by the API, | ||
| # append the results to the main list, and update the URL for the next request. | ||
| # The loop stops when there are no more pages to retrieve. | ||
| for _ in range(2, total_pages + 1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few robustness questions:
- What's a reasonable maximum number of pages?
- What happens if you hit a rate limit or timeout?
- should you throttle the calls to not be flagged as a bot or overwhelm the backend?
- Is this ever called from a request to the credentials frontend?
Description
This PR enhances the synchronization process of badge templates from the Credly API by implementing pagination support.
Previously, the fetch_badge_templates function only retrieved the first page of results (up to 50 templates).
Now, the function iterates through all available pages to fetch every active badge template, ensuring no data is missed during synchronization.
Supporting information
Testing instructions