-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: update default email setting for new_instructor_all_learners_po… #37382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: update default email setting for new_instructor_all_learners_po… #37382
Conversation
…st notification in staging
|
Thanks for the pull request, @pavanhalesh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @pavanhalesh - welcome, and thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thank you! |
|
Hey @mphilbrick211 , could you check to see if the CLA has been filled out for the new 2U engineers? I feel like I went through the processes via email, but just wasn't sure if there was anything else i needed to do to get Pavan squared away with this PR :D |
Looks like this is all set, @jsnwesson! The CLA check is green. |
|
@jsnwesson @pavanhalesh is this all set to be merged? |
Modified the default email preference for the existing notification type new_instructor_all_learners_post to enable email notifications by default for new users.
Did not rename the notification type to avoid resetting or losing existing user preferences, addressing the previous issue where renaming caused user preference resets.
This update applies only to new users. For existing users, a separate update query is required to change their email notification value from false to true.
Verified locally that newly created users now have email notifications enabled by default for this notification.

https://2u-internal.atlassian.net/jira/software/c/projects/ACT/issues/?jql=project%20%3D%20%22ACT%22%20AND%20assignee%20%3D%20currentUser%28%29%20ORDER%20BY%20created%20DESC&selectedIssue=ACT-137