Skip to content

fix: clicking on back button after post creation #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: clicking on back button after post creation #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/discussions/posts/data/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ const usePostList = (ids) => {

const sortedIds = useMemo(() => {
posts.forEach((post) => {
if (post.pinned) {
pinnedPostsIds.push(post.id);
} else {
unpinnedPostsIds.push(post.id);
if (post) {
if (post.pinned) {
pinnedPostsIds.push(post.id);
} else {
unpinnedPostsIds.push(post.id);
}
}
});

Expand Down
2 changes: 1 addition & 1 deletion src/discussions/posts/data/slices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const threadsSlice = createSlice({
if (!updatedPages[page - 1]) {
updatedPages[page - 1] = ids;
} else {
updatedPages[page - 1] = [...new Set([...updatedPages[page - 1], ...ids])];
updatedPages[page - 1] = [...new Set([updatedPages[page - 1], ...ids])];
Copy link
Preview

Copilot AI Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updatedPages[page - 1] array is not being spread into the set, which may lead to nested arrays and incorrect deduplication. Consider reverting to spreading the array as in the original code: [...new Set([...updatedPages[page - 1], ...ids])].

Suggested change
updatedPages[page - 1] = [...new Set([updatedPages[page - 1], ...ids])];
updatedPages[page - 1] = [...new Set([...updatedPages[page - 1], ...ids])];

Copilot uses AI. Check for mistakes.

}
newState.pages = updatedPages;

Expand Down