-
Notifications
You must be signed in to change notification settings - Fork 85
Replace injectIntl with the useIntl() hook #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 94.00% 94.16% +0.16%
==========================================
Files 166 166
Lines 3685 3687 +2
Branches 996 991 -5
==========================================
+ Hits 3464 3472 +8
+ Misses 206 200 -6
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c8b58a
to
3c25c43
Compare
@@ -0,0 +1,65 @@ | |||
import { fireEvent, render } from '@testing-library/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tests because codecov was failing due to coverage on this file, but i inspected the repo and TopicSearchResultBar.jsx component is never used, should we remove it? @openedx/2u-infinity
Description
As part of the project for improvements as follow up of react-unit-test-utils, we are going to replace all usages of the deprecated
injectIntl
HOC with theuseIntl()
hook from @edx/frontend-platform/i18n. It is a very straight-forward change, in order to accomplish this we did the following changes:injectIntl
, remove intl as a prop and use the hook instead.Support Information
Closes #786