[WIP] Frontendbase migration #816
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
the
mao-onboarding
| import useFeedbackWrapper from './FeedbackWrapper'; | ||
|
|
||
| const FooterSlot = lazy(() => import('@edx/frontend-component-footer').then(module => ({ default: module.FooterSlot }))); | ||
| // const FooterSlot = lazy(() => import('@edx/frontend-component-footer').then(module => ({ default: module.FooterSlot }))); |
There was a problem hiding this comment.
Should it be removed or uncommented?
There was a problem hiding this comment.
Still there while I finish figuring out that part
| {!enableInContextSidebar && isEnrolled && (<DiscussionsProductTour />)} | ||
| </main> | ||
| {!enableInContextSidebar && <FooterSlot />} | ||
| {/* TODO: verify if we can dynamically hide the Header on the new structure */} |
There was a problem hiding this comment.
Was this addressed? Same for line 82
There was a problem hiding this comment.
Not yet, that's why it's still a WIP, I'm looking for the right way
| const App = () => ( | ||
| <CurrentAppProvider appId={appId}> | ||
| <ReduxProvider store={store}> | ||
| <Outlet /> |
There was a problem hiding this comment.
I was thinking if there is no nested route it is not required to use the just use the main component instead
There was a problem hiding this comment.
I was just leaving the code ready to migrate it, because it has a complex nested route structure already but it would require a large amount of changes that I feel should be handled separetely from the frontendbase migration
| { | ||
| path: '*', | ||
| element: (<DiscussionsHome />), | ||
| // NOTE: if required we can add nested routes here while |
There was a problem hiding this comment.
Is this commented code needed?
There was a problem hiding this comment.
given that there's a really weird route structure in this project I just leaved it in case we are going to properly migrate or transform the code later (which I think should happen)
4 participants
TL;DR -
Conversion to use frontend-base and match other apps
Fixes #802
What changed?
@edx/frontend-platform***to@openedx/frontend-baseTesting Instructions
Assuming you already have everything setup in your local to run frontend-base apps
rm -rf node_modulesand reinstall them npm cinpm run devCollectively, these should be completed by reviewers of this PR: