[WIP] Set application icon in glfw #7602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build RGBA icon list and use it as icon for GLFW
…orks into Issue7590_glfwIcon
previous method depended on name specifed by the user in .rc file. The new method is independant of it.
setting icon will only work on targets that have it defined. Does nothing on targets that do not define it. Defined for TARGET_WIN32 or TARGET_LINUX
Avoid rescaling as done internally by OS. Use original image size.
|
@oxillo going to wait on this for 0.12.1 ( shortly after 0.12.0 ) just incase there are breaking issues on other platforms. |
|
@ofTheo I didn't manage to have Xcode to add it ! As GLFW do not support window icon for MacOs (and Wayland), I've thought it won't be a problem not to include it (use on these platform is guarded by #define) |
ofTheo
reviewed
Sep 28, 2023
| @@ -411,23 +405,29 @@ void ofAppGLFWWindow::setWindowIcon(const std::string & path){ | |||
|
|
|||
| //------------------------------------------------------------ | |||
| void ofAppGLFWWindow::setWindowIcon(const ofPixels & iconPixels){ | |||
| #ifndef TARGET_HAS_WINDOW_ICON | |||
There was a problem hiding this comment.
maybe add a ofLogWarning here saying platform doesn't support Window Icons :)
|
Added a comment above but happy to merge once conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7590