Skip to content

modify incorrect method name in cn.hippo4j.springboot.starter.support.DynamicThreadPoolConfigService#registerExecutor #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

modify incorrect method name in cn.hippo4j.springboot.starter.support.DynamicThreadPoolConfigService#registerExecutor #1601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...r/src/main/java/cn/hippo4j/springboot/starter/support/DynamicThreadPoolConfigService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ private ThreadPoolExecutor registerExecutor(DynamicThreadPoolRegisterWrapper reg
checkThreadPoolParameter(registerParameter);
String threadPoolId = registerParameter.getThreadPoolId();
try {
failDynamicThreadPoolRegisterWrapper(registerWrapper);
fillDynamicThreadPoolRegisterWrapper(registerWrapper);
Result registerResult = httpAgent.httpPost(REGISTER_DYNAMIC_THREAD_POOL_PATH, registerWrapper);
if (registerResult == null || !registerResult.isSuccess()) {
throw new RuntimeException("Dynamic thread pool registration returns error."
Expand Down Expand Up @@ -109,7 +109,7 @@ private void checkThreadPoolParameter(DynamicThreadPoolRegisterParameter registe
Assert.isTrue(!registerParameter.getThreadPoolId().contains("+"), "The thread pool contains sensitive characters.");
}

private void failDynamicThreadPoolRegisterWrapper(DynamicThreadPoolRegisterWrapper registerWrapper) {
private void fillDynamicThreadPoolRegisterWrapper(DynamicThreadPoolRegisterWrapper registerWrapper) {
registerWrapper.setTenantId(properties.getNamespace());
registerWrapper.setItemId(properties.getItemId());
}
Expand Down