Skip to content

fix(crash): dispatch_async retains the block but not the self #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(crash): dispatch_async retains the block but not the self #668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5c372a
Create .DS_Store
youssefmyh Dec 10, 2021
3b94550
dispatch_async crash
youssefmyh Dec 10, 2021
477c139
Delete .DS_Store
youssefmyh Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Source/AppAuthCore/OIDAuthState.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,17 @@ - (void)performActionWithFreshTokens:(OIDAuthStateAction)action
(nullable NSDictionary<NSString *, NSString *> *)additionalParameters
dispatchQueue:(dispatch_queue_t)dispatchQueue {

if ([self isTokenFresh]) {
// access token is valid within tolerance levels, perform action
dispatch_async(dispatchQueue, ^{
action(self.accessToken, self.idToken, nil);
});
return;
}
NSString * accessToken = self.accessToken;
NSString * idToken = self.idToken;
void (^block)(void) = ^(void){
action(accessToken, idToken, nil);
};

if ([self isTokenFresh]) {
// access token is valid within tolerance levels, perform action
dispatch_async(dispatchQueue, block);
return;
}

if (!_refreshToken) {
// no refresh token available and token has expired
Expand Down