Skip to content

fix: Resolved the issue where the delete message method only performs local deletion when the seq is 0 in pre-release-v3.8.4. #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix: Resolved the issue where the delete message method only performs local deletion when the seq is 0 in pre-release-v3.8.4. #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/conversation_msg/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,22 @@ func (c *Conversation) deleteMessage(ctx context.Context, conversationID string,
if err != nil {
return err
}

localMessage, err := c.db.GetMessage(ctx, conversationID, clientMsgID)
if err != nil {
return err
}

if localMessage.Status == constant.MsgStatusSendFailed {
log.ZInfo(ctx, "delete msg status is send failed, do not need delete", "msg", localMessage)
return nil
}

if localMessage.Seq == 0 {
log.ZInfo(ctx, "delete msg seq is 0, try again", "msg", localMessage)
return sdkerrs.ErrMsgHasNoSeq
log.ZInfo(ctx, "delete msg seq is 0, only delete in local", "msg", localMessage)
return c.deleteMessageFromLocal(ctx, conversationID, clientMsgID)
}

err = c.deleteMessagesFromServer(ctx, conversationID, []int64{localMessage.Seq})
if err != nil {
return err
Expand Down