Replace methods "create" in Op subclasses by constructors

[mabbay]

By using flexible constructor bodies feature, we get rid of methods "create" in Op subclasses and we replace it with constructors. We also remove unused constructors and methods in Op subclasses.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/584/head:pull/584
$ git checkout pull/584

Update a local copy of the PR:
$ git checkout pull/584
$ git pull https://git.openjdk.org/babylon.git pull/584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 584

View PR using the GUI difftool:
$ git pr show -t 584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/584.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Replace methods "create" in Op subclasses by constructors

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the code-reflection branch:

• e223619: Remove the Op copy methods
• 6922801: [hat][testing] Remote testing framework to pull all branches
• 7d39dee: HAT - New examples for optimizing matmul

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[openjdk]

@mabbay this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout rm-op-create
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

[mlbridge]

Webrevs

• 01: Full (372cc17b)
• 00: Full (2c9a0268)

[mabbay]

Babylon tests, ONXX tests and HAT violajones example, they all pass.

[PaulSandoz]

Very good, a pleasing uniformity, just one minor comment, no need for another review if to address that.

[PaulSandoz]

Group that with the other copying constructor, then its easier to see their relationship and whether we need to keep both.