8361207: Build native Windows ARM64 MSI packages #26093
Conversation
|
Hi @infeo, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user infeo" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/covered This contribution is made on behalf of the Skymatic GmbH. |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
infeo
changed the title
|
@infeo This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch @alexeysemenyukoracle can i speed up the OCA verification? |
|
@infeo The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
I just brought your case to the attention of OCA verification team. Hopefully, this will speed up the process. |
| enum Arch { | ||
| X64, | ||
| X86, | ||
| AARCH64, | ||
| OTHER; | ||
| } | ||
|
|
||
| static Arch getArch() { | ||
| if (Architecture.isX64()) { | ||
| return Arch.X64; | ||
| } else if (Architecture.isX86()) { | ||
| return Arch.X86; | ||
| } else if (Architecture.isAARCH64()) { | ||
| return Arch.AARCH64; | ||
| } else { | ||
| return Arch.OTHER; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
isn't this enum definition redundant? Why not use Architecture.current() in WixPipeline's switch expressions?
Add support for native ARM64 Windows MSI pacakges to jpackage.
For some reasoning and more info, check out the ticket on JBS: https://bugs.openjdk.org/browse/JDK-8361207.
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26093/head:pull/26093$ git checkout pull/26093Update a local copy of the PR:
$ git checkout pull/26093$ git pull https://git.openjdk.org/jdk.git pull/26093/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26093View PR using the GUI difftool:
$ git pr show -t 26093Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26093.diff