8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)

[chrisdennis]

Executors shutdown via shutdownNow() should have their cleanables cleaned to prevent a classloader leak. This can happen if a classloader exists that both references the wrapped executor and is referenced by the delegate executor.

To quote @Martin-Buchholz:

BTW: I find Cleaners much harder to use than old finalize, and it looks like I'm not the only one!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26296/head:pull/26296
$ git checkout pull/26296

Update a local copy of the PR:
$ git checkout pull/26296
$ git pull https://git.openjdk.org/jdk.git pull/26296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26296

View PR using the GUI difftool:
$ git pr show -t 26296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26296.diff

[bridgekeeper]

Hi @chrisdennis, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user chrisdennis" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@chrisdennis The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[chrisdennis]

/covered

Covered under my employment by IBM. I've set the author email on my commits to my IBM address, and I can be reached there for validation reasons if necessary. My Github user is also a member of the IBM Github organization.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[chrisdennis]

@robilad : Apologies for the direct invoke, but I've seen you facilitate this process before, so hope this is still the right way to bump things:

I've waited a "few business days" but have seen no movement on the OCA verification, and have noticed no verification email inbound to me ([email protected]).