8361638: java.lang.classfile.CodeBuilder.catchingAll doesn't throw IllegalArgumentException if an existing catch block catches all exceptions

[liach]

The detection of catch builder arguments is not working for catch-all blocks. Update this to track CP indices including 0 so we can more easily validate the incoming ClassDesc are all non-primitive and there is no duplicate.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request matching fixVersion 26 to be approved (needs to be created)

Issue

• JDK-8361638: java.lang.classfile.CodeBuilder.catchingAll doesn't throw IllegalArgumentException if an existing catch block catches all exceptions (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26372/head:pull/26372
$ git checkout pull/26372

Update a local copy of the PR:
$ git checkout pull/26372
$ git pull https://git.openjdk.org/jdk.git pull/26372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26372

View PR using the GUI difftool:
$ git pr show -t 26372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26372.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5bd5fb94)

[liach]

/csr

This will update to remove the IAE clauses and behavior, which requires a CSR.

[openjdk]

@liach has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@liach please create a CSR request for issue JDK-8361638 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.