8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events

[coffeys]

SSLLogger shouldn't be logging at the ALL level.

Trivial enough edit so that both the SSLLogger finer and finest methods log at the System.Logger.Level.TRACE value
DebugPropertyValuesTest.java edited to cover this change

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events (Bug - P4)

Reviewers

• Bradford Wetmore (@bradfordwetmore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26390/head:pull/26390
$ git checkout pull/26390

Update a local copy of the PR:
$ git checkout pull/26390
$ git pull https://git.openjdk.org/jdk.git pull/26390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26390

View PR using the GUI difftool:
$ git pr show -t 26390

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26390.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for `finest` log events

Reviewed-by: wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• e756c0d: 8361726: Shenandoah: More detailed evacuation instrumentation
• 89fe586: 8363837: Make StubRoutines::crc_table_adr() into platform-specific method
• 9e209fe: 8364110: Remove unused methods in GCCause
• ... and 76 more: https://git.openjdk.org/jdk/compare/7da274ded4a36c6314702b687fcafcda80ae08c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coffeys The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5cfce5b5)

[seanjmullan]

Seems more like a bug than an enhancement to me.

[coffeys]

Seems more like a bug than an enhancement to me.

Thanks. Corrected to bug type.

[bradfordwetmore]

I don't have a strong objection to treating FINER and FINEST as equivalent.

We currently don't really use the differing logging levels much anyway.

[coffeys]

/integrate

[openjdk]

Going to push as commit f53d051.
Since your change was applied there have been 96 commits pushed to the master branch:

• 70ebb5e: 8364019: Add alignment precondition to Universe::reserve_heap
• b4028c9: 8362482: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java: System.gc() does not provide full GC
• 08b0b34: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit
• ... and 93 more: https://git.openjdk.org/jdk/compare/7da274ded4a36c6314702b687fcafcda80ae08c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coffeys Pushed as commit f53d051.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.