-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest
log events
#26390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into |
@coffeys This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 79 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
finest
log events
Seems more like a bug than an enhancement to me. |
Thanks. Corrected to bug type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong objection to treating FINER
and FINEST
as equivalent.
We currently don't really use the differing logging levels much anyway.
/integrate |
Going to push as commit f53d051.
Your commit was automatically rebased without conflicts. |
SSLLogger shouldn't be logging at the
ALL
level.Trivial enough edit so that both the SSLLogger
finer
andfinest
methods log at theSystem.Logger.Level.TRACE
valueDebugPropertyValuesTest.java edited to cover this change
Progress
Issue
finest
log events (Bug - P4)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26390/head:pull/26390
$ git checkout pull/26390
Update a local copy of the PR:
$ git checkout pull/26390
$ git pull https://git.openjdk.org/jdk.git pull/26390/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26390
View PR using the GUI difftool:
$ git pr show -t 26390
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26390.diff
Using Webrev
Link to Webrev Comment