Skip to content

8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events #26390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Jul 18, 2025

SSLLogger shouldn't be logging at the ALL level.

Trivial enough edit so that both the SSLLogger finer and finest methods log at the System.Logger.Level.TRACE value
DebugPropertyValuesTest.java edited to cover this change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26390/head:pull/26390
$ git checkout pull/26390

Update a local copy of the PR:
$ git checkout pull/26390
$ git pull https://git.openjdk.org/jdk.git pull/26390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26390

View PR using the GUI difftool:
$ git pr show -t 26390

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26390.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8340312 8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events Jul 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@coffeys The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 18, 2025

Webrevs

@seanjmullan
Copy link
Member

Seems more like a bug than an enhancement to me.

@coffeys
Copy link
Contributor Author

coffeys commented Jul 21, 2025

Seems more like a bug than an enhancement to me.

Thanks. Corrected to bug type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants