Skip to content

Conversation

pedrolamarao
Copy link

@pedrolamarao pedrolamarao commented Jul 18, 2025

Clang 20 refuses to compile resolvedFieldEntry.cpp and resolvedMethodEntry.cpp because of applying memset to a non trivially copyable class.

Both classes seem to be defined with the intent to be trivially copyable except with pre-C++11 notation.

This patch makes copy constructors and copy assignment notations explicitly defaulted, thus satisfying the TriviallyCopyable named requirement.

With this patch, I can compile with clang 20 in CentOS Stream 10.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Warnings

 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/keystore)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/truststore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/dnsstore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/ipstore)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26391/head:pull/26391
$ git checkout pull/26391

Update a local copy of the PR:
$ git checkout pull/26391
$ git pull https://git.openjdk.org/jdk.git pull/26391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26391

View PR using the GUI difftool:
$ git pr show -t 26391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26391.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 18, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

Hi @pedrolamarao, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pedrolamarao" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@pedrolamarao The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@pedrolamarao
Copy link
Author

pedrolamarao commented Jul 18, 2025

I have just discovered I need to print and sign a paper document. I will see to it in the following days -- been some time since I last had a printer at home.

@eastig
Copy link
Member

eastig commented Jul 24, 2025

Hi @pedrolamarao,
Please read https://openjdk.org/guide/#i-have-a-patch-what-do-i-do

@pedrolamarao
Copy link
Author

Hi @eastig, I have submitted my individual contributor OCA last week.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@pedrolamarao this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout fix-compile-clang-20
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 4, 2025
@pedrolamarao
Copy link
Author

Closing this PR according with comments added to the affected files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] merge-conflict Pull request has merge conflict with target branch oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants