-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Fix compilation with clang 20 #26391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @pedrolamarao, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pedrolamarao" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
@pedrolamarao The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
I have just discovered I need to print and sign a paper document. I will see to it in the following days -- been some time since I last had a printer at home. |
Hi @pedrolamarao, |
Hi @eastig, I have submitted my individual contributor OCA last week. |
@pedrolamarao this pull request can not be integrated into git checkout fix-compile-clang-20
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Closing this PR according with comments added to the affected files. |
Clang 20 refuses to compile resolvedFieldEntry.cpp and resolvedMethodEntry.cpp because of applying memset to a non trivially copyable class.
Both classes seem to be defined with the intent to be trivially copyable except with pre-C++11 notation.
This patch makes copy constructors and copy assignment notations explicitly defaulted, thus satisfying the TriviallyCopyable named requirement.
With this patch, I can compile with clang 20 in CentOS Stream 10.
Progress
Error
Warnings
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26391/head:pull/26391
$ git checkout pull/26391
Update a local copy of the PR:
$ git checkout pull/26391
$ git pull https://git.openjdk.org/jdk.git pull/26391/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26391
View PR using the GUI difftool:
$ git pr show -t 26391
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26391.diff